scubagear messes up inventory

[Turboman.]

not really a huge bug, but sometimes it can be really annoying.

When you have the scuba gear in your inventory, and it runs out and dies, it messes up your inventory order, usually shifting the currently selected item to another (even if its not the scubagear thats selected).
this can be really annoying when lets say you have the flashlight selected, and your scuba runs out, and it automatically switches to the next item, like lets say a forcefield.

[TCP_Wolf]

This is actually a "feature". Every item that runs out will automatically call "nextItem()" as a precaution to avoid the possibility that a "none" item may be selected. This is okay when the currently selected items runs out, but very annoying if something else that wasn't the current item runs out.

I believe fixed that in UTF, but only for UTF specific items. Shouldn't be too much of a hassle to put that into the normal Unreal patch 227, if Smirftsch reminds me again when I'm home I can probably dig out the code.

[Bane]

uh. Wouldn't the fix just be a check to see if the scubagear is the currently selected item, and if not, don't call NextItem()?


Hmm. I just looked at the code. It's odd.
from UsedUp in Pickup.uc:

Code: Select all

Pawn(Owner).NextItem();
if (Pawn(Owner).SelectedItem == Self) {
      Pawn(Owner).NextItem();      
      if (Pawn(Owner).SelectedItem == Self) 
            Pawn(Owner).SelectedItem=None;
            }

I don't get why it calls next item, then checks to see if it is still selected, calls nextitem again, and THEN de-selects. It's obviously to check to see if you only have one selectable inventory item (NextItem is always the current item)... but why the hell does it test it twice?  If you can't think of a reason for that, just deleting the first NextItem call should fix the problem.

[TCP_Wolf]

Yup that's probably it. I just can't look up code at work and when I'm home I am usually doing other things than remembering what I wanted to post